- From: Sun Shin <notifications@github.com>
- Date: Sat, 11 May 2024 15:12:39 -0700
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 11 May 2024 22:12:43 UTC
@xingri commented on this pull request. > @@ -878,8 +883,15 @@ <h3> <li>Initialize |buttons| to be an empty [=list=]. </li> <li>[=list/For each=] |buttonIndex:long| of [=the range=] from 0 to - |buttonsSize| − 1, [=list/append=] a [=new=] {{GamepadButton}} to - |buttons|. + |buttonsSize| − 1: + <ol> + <li>Determine the |type| of the button from the provided {{GamepadButtonType}} @nondebug thanks for the review and detailed guide. Updated this PR to reflect the feedbacks. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/196#discussion_r1597514393 You are receiving this because you are subscribed to this thread. Message ID: <w3c/gamepad/pull/196/review/2051262995@github.com>
Received on Saturday, 11 May 2024 22:12:43 UTC