Re: [w3c/gamepad] Add vendorId, productId, name attributes (PR #202)

@marcoscaceres commented on this pull request.



> +              <li>If the gamepad has vendor and product identifiers:
+                <ol>
+                  <li>Initialize |gamepad|.{{Gamepad/vendorId}} to the vendor
+                  identifier.
+                  </li>
+                  <li>Initialize |gamepad|.{{Gamepad/productId}} to the product
+                  identifier.
+                  </li>
+                </ol>
+              </li>
+              <li>Otherwise:
+                <ol>
+                  <li>Initialize |gamepad|.{{Gamepad/vendorId}} to `null`.
+                  </li>
+                  <li>Initialize |gamepad|.{{Gamepad/productId}} to `null`.
+                  </li>
+                </ol>
+              </li>
+              <li>Initialize |gamepad|'s {{Gamepad/name}} attribute to a
+              human-readable identifier for the gamepad.
+              </li>

Maybe just: 

```suggestion
              <li>Initialize |gamepad|.{{Gamepad/vendorId}} to `null`</li>
              <li>Initialize |gamepad|.{{Gamepad/productId}} to `null`.</li>
              <li>If the gamepad has vendor and product identifiers:
                <ol>
                  <li>Set |gamepad|.{{Gamepad/vendorId}} to the vendor
                  identifier.
                  </li>
                  <li>Set |gamepad|.{{Gamepad/productId}} to the product
                  identifier.
                  </li>
                </ol>
              </li>
              <li>Initialize |gamepad|'s {{Gamepad/name}} attribute to a
              human-readable identifier for the gamepad.
              </li>
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/202#pullrequestreview-2049028634
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/202/review/2049028634@github.com>

Received on Thursday, 9 May 2024 23:55:19 UTC