- From: Dominic Farolino <notifications@github.com>
- Date: Wed, 08 May 2024 13:22:37 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1261/review/2046567350@github.com>
@domfarolino commented on this pull request. > + modify the tree's structure, making live traversal unsafe, possibly leading to the + <a>post-insertion steps</a> being called multiple times on the same <a>node</a>.</p> + </li> + + <li> + <p>For each <var>node</var> in <var>nodes</var>, in <a>tree order</a>: + + <ol> + <li><p>For each <a>shadow-including inclusive descendant</a> <var>inclusiveDescendant</var> of + <var>node</var>, in <a>shadow-including tree order</a>, <a for=list>append</a> + <var>inclusiveDescendant</var> to <var>staticNodeList</var>. + </ol> + </li> + + <li><p><a for=list>For each</a> <var>node</var> in <var>staticNodeList</var>, if <var>node</var> is + <a>connected</a>, then run the <a>post-insertion steps</a> with <var>node</var>. Hmm, I see the point. For selfish implementer reasons I would gently push back just because both the WebKit and Blink use the word "insertion" in their representations of these steps, so reducing cognitive overhead for implementers seems like a good thing to me. But I am not married to it. If we really wanted to change this, I would! -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1261#discussion_r1594582788 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1261/review/2046567350@github.com>
Received on Wednesday, 8 May 2024 20:22:41 UTC