Re: [w3c/pointerlock] Add lock options to requestPointerLock (#49)

@marcoscaceres commented on this pull request.



> +                    <li>[=Reject=] <var>promise</var> with a
+                    "{{NotSupportedError}}" {{DOMException}}.
+                    </li>
+                  </ol>
+                </li>
+                <li>Return <var>promise</var>.
+                </li>
+              </ol>
+              <aside class="note" data-link-for="Document">
+                "{{NotSupportedError}}" {{DOMException}} should be reserved for
+                unsupported options in future iterations of this spec. That is,
+                no other error conditions should use "{{NotSupportedError}}",
+                so that web developers can use it for feature testing.
+              </aside>
+            </li>
+            <li>If none of the above errors have occured

One check we are missing is for Document's visibility state. A hidden document shouldn't be allowed to request pointer lock. 

I'll file a bug for that. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/pointerlock/pull/49#pullrequestreview-2041892320
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/pointerlock/pull/49/review/2041892320@github.com>