Re: [w3c/manifest] fix: dir's auto definition (PR #1118)

@mgiuca requested changes on this pull request.

I think we can fix up some other text in this section while we're here.

1. "implying that the value of the localizable members is by default:" -- I don't know how to parse this part of the sentence (it's right before the list of options). Delete it.

2. "the use agent SHOULD" - s/use/user/

3. Replace "When displaying the localizable members to an end-user..." with:

"The user agent SHOULD display the localizable members to the end-user using the [BIDI] algorithm. If the base direction is ltr or rtl, the user agent SHOULD override Rule P3 of [BIDI] ..."

(Remove the ordered list and drop list item 2 entirely - there is no need to explicitly state what happens in the "auto" case since it's covered by Bidi automatically. And we already have non-normative text to explain what happens in this case, above.)

(Also, it shouldn't say "apply Rule P1"; rule P2 is where the first strong character is chosen. But I would advise deleting this sentence entirely.)

> @@ -473,7 +473,17 @@ <h3>
             "<dfn data-dfn-for="text-direction">auto</dfn>" (default)
           </dt>
           <dd>
-            No explicit directionality.
+            <p>
+              Direction determined from content using the first-strong part of

Replace "the first strong part" with "Rule P2". (Elsewhere, we link to those rules like this: `<a data-cite="bidi#P2">Rule P2</a>` -- not sure if there is a more Respeccy way to link that.)

Note: Even though it doesn't explicitly say this, I consider this to be non-normative text (since it is just giving a human-readable summary of what this value means). The "when displaying" algorithm below gives the actual normative statement. So it isn't necessary to have this be entirely precise, but I think it helps to link to the exact part of the algorithm.

> @@ -473,7 +473,17 @@ <h3>
             "<dfn data-dfn-for="text-direction">auto</dfn>" (default)
           </dt>
           <dd>
-            No explicit directionality.
+            <p>
+              Direction determined from content using the first-strong part of
+              the [[BIDI]] algorithm.
+            </p>
+            <aside class="note">
+              <p>
+                An explicit direction value such as "[=text-direction/rtl=]" or

Since my above comment makes the meaning of auto less clear, add to the front here: "Using `[=text-direction/auto=]` means that the directionality of each member will be determined by its first strongly directional character. An explicit  ....."

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1118#pullrequestreview-2039869800
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1118/review/2039869800@github.com>