- From: smaug---- <notifications@github.com>
- Date: Thu, 02 May 2024 14:28:14 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 2 May 2024 21:28:18 UTC
@smaug---- commented on this pull request. > + modify the tree's structure, making live traversal unsafe, possibly leading to the + <a>post-insertion steps</a> being called multiple times on the same <a>node</a>.</p> + </li> + + <li> + <p>For each <var>node</var> in <var>nodes</var>, in <a>tree order</a>: + + <ol> + <li><p>For each <a>shadow-including inclusive descendant</a> <var>inclusiveDescendant</var> of + <var>node</var>, in <a>shadow-including tree order</a>, <a for=list>append</a> + <var>inclusiveDescendant</var> to <var>staticNodeList</var>. + </ol> + </li> + + <li><p><a for=list>For each</a> <var>node</var> in <var>staticNodeList</var>, if <var>node</var> is + <a>connected</a>, then run the <a>post-insertion steps</a> with <var>node</var>. Why do we have the requirement for the node to be connected? (It wasn't clear to me either when looking at blink's source code, but I didn't look at the blame for that part). -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1261#pullrequestreview-2036964119 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1261/review/2036964119@github.com>
Received on Thursday, 2 May 2024 21:28:18 UTC