- From: Matt Giuca <notifications@github.com>
- Date: Tue, 30 Apr 2024 23:24:33 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1114/review/2033105125@github.com>
@mgiuca commented on this pull request. > @@ -759,10 +759,11 @@ <h3> <p> The [=manifest's=] <code><dfn data-export="" data-dfn-for= "manifest">start_url</dfn></code> member is a <a>string</a> that - represents the <dfn>start URL</dfn> , which is <a>URL</a> that the - developer would prefer the user agent load when the user launches the - web application (e.g., when the user clicks on the icon of the web - application from a device's application menu or homescreen). + represents the <dfn data-export="">start URL</dfn> , which is This is commenting on a PR that was already submitted (#1112). (It just got caught up in this PR's delta because it wasn't submitted at the time I uploaded this.) I've rebased now, which should make things clearer. You may be right, but I would like you to put this up as a separate PR if you don't mind. It's a bit complex as I've now got text in [manifest-incubations](https://wicg.github.io/manifest-incubations/#home_tab-member) which links to this and will have to be updated when you make this change. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1114#discussion_r1585933652 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1114/review/2033105125@github.com>
Received on Wednesday, 1 May 2024 06:24:37 UTC