- From: Luke Warlow <notifications@github.com>
- Date: Wed, 27 Mar 2024 12:22:43 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1268@github.com>
This calls the get Trusted Types-compliant attribute value algorithm from Trusted Types (https://github.com/w3c/trusted-types/pull/418) from attribute's change, append, and replace. Changed the signature of setAttribute and setAttributeNS to accept Trusted Types as values. The underlying Attr node's values continue to be DOMString, so moving nodes across elements or adding standalone attributes to elements can cause TT violations. This matches WPT tests and the Chromium's implementation. See and https://github.com/whatwg/dom/issues/789. Supercedes PR https://github.com/whatwg/dom/pull/809. - [x] At least two implementers are interested (and none opposed): * Chromium * Gecko - [x] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * https://github.com/web-platform-tests/wpt/tree/master/trusted-types - [x] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chromium:https://bugs.chromium.org/p/chromium/issues/detail?id=739170 * Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1508286 * WebKit: https://bugs.webkit.org/show_bug.cgi?id=266630 - [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: … - [ ] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. --> (See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.) You can view, comment on, or merge this pull request online at: https://github.com/whatwg/dom/pull/1268 -- Commit Summary -- * Draft integration with Trusted Types, take 2. * Added integration in 'set an attribute value'. * Removed stringification. * Fixed formatting. * Fixed copy-paste error in setAttribute() and indentation. -- File Changes -- M dom.bs (72) -- Patch Links -- https://github.com/whatwg/dom/pull/1268.patch https://github.com/whatwg/dom/pull/1268.diff -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1268 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1268@github.com>
Received on Wednesday, 27 March 2024 19:22:47 UTC