Re: [whatwg/dom] Introduce DOM post-insertion steps (PR #1261)

@domfarolino commented on this pull request.



> @@ -2752,6 +2812,16 @@ before a <var>child</var>, with an optional <i>suppress observers flag</i>, run
  <var>parent</var> with <var>nodes</var>, « », <var>previousSibling</var>, and <var>child</var>.
 
  <li><p>Run the <a>children changed steps</a> for <var>parent</var>.
+
+ <li>
+  <p>For each <var>node</var> in <var>nodes</var>, in <a>tree order</a>:
+
+  <ol>
+   <li><p>For each <a>shadow-including inclusive descendant</a> <var>inclusiveDescendant</var> of
+   <var>node</var>, in <a>shadow-including tree order</a>, run the <a>post-insertion steps</a> with
+   <var>inclusiveDescendant</var>.
+  </ol>
+ </li>

I don't know what a script runner is. But if you have a concrete test case that shows how Gecko deviates from the spec here, that would be great. Two points though:

 - This PR doesn't actually make changes to script execution. That would be https://github.com/whatwg/html/pull/10188, which I'd be grateful for your review on as well!
 - The combined behavior change of both this PR and https://github.com/whatwg/html/pull/10188 is captured by [these tests](https://wpt.fyi/results/dom/nodes/insertion-removing-steps?label=experimental&label=master&aligned). We'd love for you to weigh on the test expectations over in https://github.com/whatwg/html/pull/10188, to see if any of the significant Firefox failures are a result of inappropriate test expectations.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1261#discussion_r1539786429
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1261/review/1961223391@github.com>