Re: [w3c/gamepad] Add extended buttons to support trackpad (#191) (PR #196)

@marcoscaceres commented on this pull request.



> @@ -952,6 +953,17 @@ <h2>
             .. 1.0]
           </td>
         </tr>
+        <tr>
+          <td>
+            <dfn data-dfn-for="GamepadButton">[[\type]]</dfn>
+          </td>
+          <td>
+            `undefined`
+          </td>
+          <td>
+            Indicates the button type the controller is held in.

```suggestion
            The button type of the controller.
```

> +            <tr>
+              <td>squeeze_right_lower</td>
+              <td>Xbox Elite Wireless Controller</td>
+            </tr>
+          </tbody>
+        </table>
+ <section>
+          <h3>
+            <dfn>GamepadButtonType</dfn> Enum
+          </h3>
+          <p>
+            This enum defines the set of possible button types.
+          </p>
+          <pre class="idl">
+            enum GamepadButtonType {
+              "",  /* unknown, or not applicable */

Better to make it explicit.

```suggestion
              "unknown",
```

And if not applicable, maybe we should make . type nullable? 

> -            <td>
-              axes[3]
-            </td>
-            <td>
-              Vertical axis for right stick (negative up/positive down)
-            </td>
-          </tr>
-        </tbody>
-      </table>
-      <figure>
-        <img src="standard_gamepad.svg" alt="">
-        <figcaption>
-          Visual representation of a [=Standard Gamepad=] layout.
-        </figcaption>
-      </figure>
+      <section>

@xingri, would it be possible to revert some of this so it only shows what you changed? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/196#pullrequestreview-1958863543
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/196/review/1958863543@github.com>