Re: [w3c/ServiceWorker] Implement the "not" condition support (PR #1711) from Domenic Denicola on 2024-03-26 (public-webapps-github@w3.org from March 2024)

From: Domenic Denicola <notifications@github.com>
Date: Tue, 26 Mar 2024 01:20:14 -0700
To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <w3c/ServiceWorker/pull/1711/review/1959620432@github.com>

@domenic approved this pull request.

LGTM with one fix

> @@ -1578,6 +1578,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
         RunningStatus runningStatus;
 
         sequence&lt;RouterCondition&gt; _or;
+        RouterCondition _not;

I think this one does not need escaping, so just `not` is OK?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1711#pullrequestreview-1959620432
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1711/review/1959620432@github.com>

Received on Tuesday, 26 March 2024 08:20:18 UTC