- From: Alvin Ji <notifications@github.com>
- Date: Fri, 22 Mar 2024 19:17:19 -0700
- To: w3c/pointerlock <pointerlock@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 23 March 2024 02:17:23 UTC
@alvinjiooo commented on this pull request.
> @@ -335,19 +336,19 @@ <h2>
<ol class="algorithm">
<li>Let |promise:Promise| be [=a new promise=].
</li>
- <li>When a window is in focus, if the [=this=]'s [=shadow-including
- root=] is the [=navigable/active document=] of a [=Document/browsing
- context=] (or has an [=tree/ancestor=] [=browsing context=]) which is not in
- focus:
+ <li>When a {{Window/window}} is in [=Window/focus=], if the [=this=]'s
+ [=shadow-including root=] is the [=navigable/active document=] of a
+ [=Document/browsing context=] (or has an [=tree/ancestor=]
+ [=browsing context=]) which is not in focus:
Done, as for the comment to original algorithm I will propose an updated algorithm in https://github.com/w3c/pointerlock/pull/49/files#r1373662771 and review it again from there.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/pointerlock/pull/49#discussion_r1536541283
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/pointerlock/pull/49/review/1956280861@github.com>
Received on Saturday, 23 March 2024 02:17:23 UTC