Re: [w3c/selection-api] Fixes https://github.com/w3c/selection-api/issues/170. (PR #172)

@annevk commented on this pull request.



> @@ -180,6 +180,10 @@ <h2>
         in the [=document tree=]. It could be in a [=shadow tree=] of
         the same [=document=].
       </p>
+      <p>
+        Each <a>document</a>, <a>input</a> element, and <a>textarea</a> element has a boolean flag
+        <dfn>has scheduled selectionchange event</dfn>, which is initially false.

I'd remove "flag" here. It's redundant with boolean and we stopped using flag in favor of boolean elsewhere.

>          </p>
+        <section>
+          <h4>Scheduling <code>selectionhange</code> event</h4>
+          <p>To <dfn>schedule a selectionchange event</dfn> on a node <var>target</var>, run these steps:</p>
+          <ol>
+            <li>
+              If <var>target</var>'s <a>has scheduled selectionchange event</a> flag is true,
+              abort these steps.
+            </li>
+            <li>
+              <a>Queue a task</a> on the <a>user interaction task source</a> to

Instead of queue a task, you want https://html.spec.whatwg.org/#queue-an-element-task and also pass that _target_. This way some aspects of the task get better initialized.

(We want to eventually remove "queue a task".)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/selection-api/pull/172#pullrequestreview-1939661009
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/selection-api/pull/172/review/1939661009@github.com>