- From: Luke Warlow <notifications@github.com>
- Date: Wed, 13 Mar 2024 05:18:01 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/webidl/pull/1392/review/1933969885@github.com>
@lukewarlow commented on this pull request. > @@ -11092,8 +11139,16 @@ Note: The HTML Standard defines how a security check is performed. [[!HTML]] 1. If the argument at index |i| is declared with a [=optional argument/default value=], then append to |values| that default value. 1. Otherwise, append to |values| the special value “missing”. - 1. Otherwise, append to |values| the result of [=converted to an IDL value|converting=] - |V| to IDL type |type|. + 1. Otherwise: + 1. If |type| is an IDL type [=extended attribute associated with|associated with=] the + [{{StringContext}}] extended attribute, then set |V| to the result of performing + [=validate the string in context=], passing [=this=], |V|, the {{StringContext}} + extended attribute [=identifier=], and the [=identifier=] + of the [=operation=] or [=extended attribute=] of the first entry in |S|. Yeah based on my understanding you can't really have overloads. Like where you need the type to be different in a sub class we just switch back to using a union type and handling it manually rather than using this attribute. cc @koto in case I'm wrong. Happy to add a note or something to make it clearer, not really sure what it should say though? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/webidl/pull/1392#discussion_r1523124234 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/webidl/pull/1392/review/1933969885@github.com>
Received on Wednesday, 13 March 2024 12:18:05 UTC