Re: [whatwg/dom] Integration with trusted types inside of node conversion (PR #1258)

@annevk commented on this pull request.

This looks complicated. Any reason we cannot convert to Text nodes first and then potentially throw for Text nodes if they pose some kind of danger in combination with a `script` element?

>  
 <ol>
+ <li><p>Let <var>isScriptElement</var> be <var>parent</var> is a {{HTMLScriptElement}}.
+ <li><p>For each <var>value</var> in <var>nodes</var>:
+  <ol>
+   <li>If <var>value</var> is a <a for=/>node</a>, then:
+    <ol>
+     <li>If <var>isScriptElement</var> is false, skip to the next <var>value</var>.

then continue* (see also Infra)

>  
 <ol>
+ <li><p>Let <var>isScriptElement</var> be <var>parent</var> is a {{HTMLScriptElement}}.
+ <li><p>For each <var>value</var> in <var>nodes</var>:
+  <ol>
+   <li>If <var>value</var> is a <a for=/>node</a>, then:
+    <ol>
+     <li>If <var>isScriptElement</var> is false, skip to the next <var>value</var>.
+      <li>If <var>value</var>'s {{nodeType}} is not {{TEXT_NODE}}, skip to the next <var>value</var>.

Please compare the class instead as we do elsewhere in this standard. That would also encompass CDATASection.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1258#pullrequestreview-1914212737
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1258/review/1914212737@github.com>

Received on Monday, 4 March 2024 12:41:54 UTC