- From: Addison Phillips <notifications@github.com>
- Date: Sun, 23 Jun 2024 12:29:17 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Sunday, 23 June 2024 19:29:21 UTC
@aphillips approved this pull request.
Looks good to me, but a suggestion for a small improvement
> @@ -446,9 +446,9 @@ <h3>
</h3>
<p>
The [=manifest's=] <code><dfn data-export="" data-dfn-for=
- "manifest">dir</dfn></code> member specifies the <dfn>base
- direction</dfn> for the <a>localizable members</a> of the
- <a>manifest</a>. The [=manifest/dir=] member's value can be set to a
+ "manifest">dir</dfn></code> member specifies the string direction for
I would probably say that this is the _default_ string direction, since individual members can override the direction. I would probably also linkify the term "string direction" (to the I18N glossary) to ensure that the meaning is clear.
```suggestion
"manifest">dir</dfn></code> member specifies the default [=string direction=] for
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1135#pullrequestreview-2134393272
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/manifest/pull/1135/review/2134393272@github.com>
Received on Sunday, 23 June 2024 19:29:21 UTC