- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 13 Jun 2024 05:53:58 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1757/review/2115699489@github.com>
@annevk approved this pull request. Thanks, this looks reasonable to me modulo nits. This means that service workers do not get to see the header ever unless it was set by a web developer. Do we have test coverage for that as well? > @@ -5654,6 +5654,12 @@ run these steps: default), and `<code>Accept-Charset</code>` is a waste of bytes. See <a>HTTP header layer division</a> for more details. + <li><p>If <var>httpRequest</var>'s <a for=request>header list</a> + <a for="header list">does not contain</a> `<code>Priority</code>`, then user agents may This and below should not be indented extra. Please align with `<li><p>`. > @@ -5654,6 +5654,12 @@ run these steps: default), and `<code>Accept-Charset</code>` is a waste of bytes. See <a>HTTP header layer division</a> for more details. + <li><p>If <var>httpRequest</var>'s <a for=request>header list</a> + <a for="header list">does not contain</a> `<code>Priority</code>`, then user agents may + <a for="header list">append</a> a `<code>Priority</code>` <a>header</a> with an + <a>implementation-defined</a> value derived from <var>httpRequest</var>'s + <a for=request>internal priority</a> in accordance with RFC 9218. [[!RFC9218]] `<cite>RFC 9218</cite>` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1757#pullrequestreview-2115699489 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1757/review/2115699489@github.com>
Received on Thursday, 13 June 2024 12:54:02 UTC