- From: Christian Liebel <notifications@github.com>
- Date: Sat, 08 Jun 2024 02:45:00 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 8 June 2024 09:45:04 UTC
@christianliebel commented on this pull request.
> + This member is a [=localizable member=]. Setting a [=text-direction=]
+ is not supported and will be ignored.
I wonder whether this scenario should be supported at all:
```
{
"icons_localized": {
"fr": { "lang": "de", "dir": "rtl", value: [] }
}
}
```
Alternatively, we could also distinguish between text localizations (where we would support changing `lang`/`dir`) and image resource localizations where we would *only* allow setting the usual member value (image resource array):
```
{
"icons_localized": {
"fr": []
}
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1101#discussion_r1632001773
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/manifest/pull/1101/review/2105810240@github.com>
Received on Saturday, 8 June 2024 09:45:04 UTC