- From: Mustaq Ahmed <notifications@github.com>
- Date: Thu, 06 Jun 2024 08:13:09 -0700
- To: w3c/pointerlock <pointerlock@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 6 June 2024 15:13:13 UTC
I am approving the PR based on the following points: - On May 6 2024 @marcoscaceres called a virtual meeting to help us resolve the remaining comments in the original PR (#49). The meeting was attended by @alvinjiooo, @james-howard, @marcoscaceres, @mustaqahmed, @nondebug and @scheib. We agreed that landing the PR makes the spec better match the implementations, and decided to land it after adding & linking new spec issues for the remaining TODOs there. - I approved the original PR after @alvinjiooo addressed the remaining TODOs there. - The original PR has been blocked by an "ipr" check for a while because @NavidZ is no longer a participant of WebApps WG. We didn't find a way to resolve this blocker quickly. - To bypass the "ipr" check, @alvinjiooo created this PR and I closed #49. - Just now, I confirmed by local diffing that #49 and #99 match exactly, so my approval there logically carries over to this PR. --- I second @scheib in thanking everyone for their patience with #49 (which was about to become ~5 years old 😞), especially @NavidZ, @jameshollyergoogle, @alvinjiooo, @domenic and @marcoscaceres. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/pointerlock/pull/99#issuecomment-2152785160 You are receiving this because you are subscribed to this thread. Message ID: <w3c/pointerlock/pull/99/c2152785160@github.com>
Received on Thursday, 6 June 2024 15:13:13 UTC