- From: Jamie Mansfield <notifications@github.com>
- Date: Mon, 22 Jul 2024 12:11:27 -0700
- To: w3c/uievents <uievents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/uievents/pull/379@github.com>
This matches all other initUIEvent methods, the existing parameter explanations of the spec, [Firefox](https://searchfox.org/mozilla-central/source/dom/webidl/CompositionEvent.webidl#39), and [Chromium](https://github.com/chromium/chromium/blob/20be7de2e281fe8481a75713ead9d25d5c741515/third_party/blink/renderer/core/events/composition_event.idl#L38). Although WebKit uses WindowProxy, it's worth noting that it uses it in place of Window for other UIEvents too. (they have a [FIXME for KeyboardEvent](https://github.com/WebKit/WebKit/blob/75ba0c46a4b93f5162d2c4f21efebcdd1e333110/Source/WebCore/dom/KeyboardEvent.idl#L53) for example) The following tasks have been completed: * [ ] Confirmed there are no ReSpec/BikeShed errors or warnings. * [ ] Modified Web platform tests (link to pull request) Implementation commitment: * [ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=) * [x] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=) (N/A as they already use Window) * [x] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=) (N/A as they already use Window) You can view, comment on, or merge this pull request online at: https://github.com/w3c/uievents/pull/379 -- Commit Summary -- * Make CompositionEvent.init take a Window rather than WindowProxy -- File Changes -- M sections/legacy-event-initializers.txt (2) -- Patch Links -- https://github.com/w3c/uievents/pull/379.patch https://github.com/w3c/uievents/pull/379.diff -- Reply to this email directly or view it on GitHub: https://github.com/w3c/uievents/pull/379 You are receiving this because you are subscribed to this thread. Message ID: <w3c/uievents/pull/379@github.com>
Received on Monday, 22 July 2024 19:11:31 UTC