Re: [whatwg/streams] Use `async iterable` webidl type in ReadableStream.from (PR #1310)

@MattiasBuelens commented on this pull request.

Still LGTM, with one small nit.

> +  1. Return the result of [=reacting=] to |finishPromise|:
+    - If |finishPromise| was fulfilled, return undefined.
+    - If |finishPromise| was rejected with reason |r|, throw |r|.

Nit-pick: can we return `finishPromise` as-is? It looks like [the close algorithm in IDL](https://whatpr.org/webidl/1397.html#async-iterable-close) already does the right thing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1310#pullrequestreview-2183658059
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1310/review/2183658059@github.com>