- From: Domenic Denicola <notifications@github.com>
- Date: Tue, 16 Jul 2024 18:27:41 -0700
- To: whatwg/webidl <webidl@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 17 July 2024 01:27:45 UTC
@domenic commented on this pull request. Awesome, happy to have this here. Just one question. I don't think the PR template is necessary for this kind of definition. > @@ -9054,6 +9054,21 @@ a reference to the same object that the IDL value represents. 1. Return [$IsDetachedBuffer$](|jsArrayBuffer|). </div> +<div algorithm> + A [=buffer source type=] instance |bufferSource| is + <dfn for="BufferSource" export>detachable</dfn> if the following steps return true: + + 1. Let |jsArrayBuffer| be the result of [=converted to a JavaScript value|converting=] + |bufferSource| to a JavaScript value. + 1. If |jsArrayBuffer| has a \[[ViewedArrayBuffer]] internal slot, then set |jsArrayBuffer| to + |jsArrayBuffer|.\[[ViewedArrayBuffer]]. + 1. If [$IsSharedArrayBuffer$](|jsArrayBuffer|) is true, then return false. + 1. If [$IsDetachedBuffer$](|jsArrayBuffer|) is true, then return false. Hmm, this step is a bit surprising. Is it helpful for your use case? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/webidl/pull/1419#pullrequestreview-2181636737 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/webidl/pull/1419/review/2181636737@github.com>
Received on Wednesday, 17 July 2024 01:27:45 UTC