- From: Addison Phillips <notifications@github.com>
- Date: Sat, 13 Jul 2024 06:34:45 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 13 July 2024 13:34:49 UTC
@aphillips commented on this pull request. > @@ -549,13 +534,7 @@ <h3> <li>If |json|["lang"] doesn't [=map/exist=] or if |json|["lang"] is not a [=string=], return. </li> - <li>If calling <a data-cite= Note that the comment is about _matching_ language tags. _Parsing_ language tags is more straightforward. It's a good idea to check if the tag is what BCP47 calls "well formed". (BCP47 defined two levels of tag conformance. A tag can be grammatically correct ['well formed'] and it can contain only registered subtags with other restrictions ['valid']. Unfortunately, 402 named the "well-formed-checking" thing `IsStructurallyValidLanguageTag`). In general, few specifications require validity checking of the tags, because that requires access to (a copy of) the IANA Language Subtag Registry, but well-formed checking helps users avoid putting invalid strings in. The canonicalization of language tags is into locale IDs is probably fine. So perhaps put this text back? -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1101#discussion_r1676826362 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1101/review/2176259495@github.com>
Received on Saturday, 13 July 2024 13:34:49 UTC