- From: Julien Cayzac <notifications@github.com>
- Date: Fri, 12 Jul 2024 20:10:05 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Saturday, 13 July 2024 03:10:09 UTC
@jcayzac commented on this pull request. > + `lang` (optional) + </dt> + <dd> + A [=language tag=]. + </dd> + <dt> + `dir` (optional) + </dt> + <dd> + The [=text-direction=]. + </dd> + </dl> + <p> + When a plain [=string=] is used, or when the `lang` or `dir` + members are omitted, `lang` falls back the [=language tag=] of the + [=language map=] key, and `dir` falls back to the [=manifest/dir=] To make it even less ambiguous, I would just get rid of the language map and replace it with an array of objects: ```json "name_localized": [ { "lang": "de", "value": "Farbwähler" }, { "lang": "en", "value": "Color Picker" }, { "lang": "en-GB", "value": "Colour Picker" }, { "lang": "fr", "value": "Sélecteur de Couleur" }, { "lang": "fr-CA, fr-BE", "value": "Sélecteur des Couleurs" }, { "lang": "ar", "value": "منتقي الألوان", "dir": "rtl" } ] ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1101#discussion_r1676695978 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1101/review/2176068148@github.com>
Received on Saturday, 13 July 2024 03:10:09 UTC