- From: Marcos Cáceres <notifications@github.com>
- Date: Wed, 10 Jul 2024 18:00:41 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 11 July 2024 01:00:45 UTC
@marcoscaceres commented on this pull request. > + `lang` (optional) + </dt> + <dd> + A [=language tag=]. + </dd> + <dt> + `dir` (optional) + </dt> + <dd> + The [=text-direction=]. + </dd> + </dl> + <p> + When a plain [=string=] is used, or when the `lang` or `dir` + members are omitted, `lang` falls back the [=language tag=] of the + [=language map=] key, and `dir` falls back to the [=manifest/dir=] I'm having trouble following this... I think you should make two paragraphs here, one for dir and one for lang. I was expecting the lang to fall back to to the lang defined at the root of the manifest. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1101#pullrequestreview-2170675810 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1101/review/2170675810@github.com>
Received on Thursday, 11 July 2024 01:00:45 UTC