Re: [whatwg/streams] Update endpoint pair example and fix citation (PR #1318)

@domenic requested changes on this pull request.



>  
  <xmp highlight="js">
- const { readable, writable } = createEndpointPair();
- readable.pipeThrough(new TransformStream(...)).pipeTo(writable);
+ async function handleTransformer({readable, writable}) {
+   await readable.pipeThrough(new TransformStream(...)).pipeTo(writable);
+ }
  </xmp>

This example has been simplified a bit too much I think. It talks about a platform-provided `Transformer` interface but that interface is now super-implicit, because of the destructuring of function arguments. I think reverting to something like

```js
const { readable, writable } = createTransformer();
readable.pipeThrough(new TransformStream(...)).pipeTo(writable);
```

would work better.

Additionally, the point of `createEndpointPair()` was to match the official name given in the standard, "endpoint pair". So I think that that was even better.

Can you say more about why you changed this example?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1318#pullrequestreview-2168093847
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1318/review/2168093847@github.com>