Re: [w3c/push-api] Correct PushMessageData (PR #382)

@saschanaz commented on this pull request.

It seems PushMessageData is only set for PushEvent if any buffer exists and otherwise `data` becomes null, and PushMessageData itself does not expect null. [Gecko does not expect null either](https://searchfox.org/mozilla-central/rev/ab488b411ff15c2e11dbd4d6be0455bb64bc8fc1/dom/serviceworkers/ServiceWorkerEvents.h#221), so it matches the implementation. (I assume you checked WebKit, but [it seems WebKit does not either](https://searchfox.org/wubkat/rev/df1e46cebe93c020392645e94f67469843cd8063/Source/WebCore/Modules/push-api/PushMessageData.h#44).)

>        </p>
       <p>
-        The <dfn>blob()</dfn> method, when invoked, MUST return a {{Blob}} whose contents are
-        |bytes| and |type| is not provided.
+        The <dfn>blob()</dfn> method steps are to return a new {{Blob}} object whose contents are
+        <a>this</a>'s <a data-dfn-for=PushMessageData>bytes</a>.

I believe that convention is just because of this file is old and we don't have to maintain high verbosity 😛

>        </p>
       <p>
-        The <dfn>blob()</dfn> method, when invoked, MUST return a {{Blob}} whose contents are
-        |bytes| and |type| is not provided.
+        The <dfn>blob()</dfn> method steps are to return a new {{Blob}} object whose contents are
+        <a>this</a>'s <a data-dfn-for=PushMessageData>bytes</a>.

BTW is it intentional to remove the mention of type?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/pull/382#pullrequestreview-2166774372
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/push-api/pull/382/review/2166774372@github.com>