- From: Addison Phillips <notifications@github.com>
- Date: Sat, 06 Jul 2024 07:37:47 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1101/review/2161538707@github.com>
@aphillips approved this pull request. Minor comments. Looks good! Thanks. > @@ -1543,6 +1764,13 @@ <h3> The user agent MAY automatically apply the changes if the update does not contain changes to [=security-sensitive members=]. </p> + <p> + If a user changes localization settings, the user agent MAY You might also want to mention that, regardless of the direction (`dir`) of the localized value, the security sensitive members should be displayed in a bidirectionally isolated way to prevent the kinds of display problems described in [Unicode Source Code Handling](https://www.unicode.org/reports/tr55) [UTR55]. > @@ -3294,6 +3549,16 @@ <h2> using one of the following options: </p> <dl> + <dt> + Localized values in the manifest: + </dt> + <dd> + Authors can provide [=localized values=] for the [=localizable + members=] of the [=manifest=]. The user agent should pass all should or SHOULD? > + the application. The user agent SHOULD use the user's localization + settings to select the [=localized value=] whose language tag best Perhaps: ```suggestion the application. The user agent SHOULD use the user's localization settings ([=locale=]) to select the [=localized value=] whose language tag best ``` -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1101#pullrequestreview-2161538707 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1101/review/2161538707@github.com>
Received on Saturday, 6 July 2024 14:37:51 UTC