Re: [w3c/gamepad] Add vibrationActuator to the main spec (PR #190)

@toji approved this pull request.

Change LGTM, thanks for the update! And, to reiterate, I agree with the decision to leave `pulse()` in the extensions doc, given the confusion around it and it's intended behavior.

I appreciate the explicit "completed"/"preempted" status of `playEffect()` in this regard, and would recommend that if `pulse()` is carried forward that it may be worth evaluating whether or not to transition to that model for consistency and clarity. (Since the enums will evaluate to be truthy and existing implementations have apparently only ever returned true this is maybe a reasonable backwards compat break.)



-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/190#pullrequestreview-1828300254
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/190/review/1828300254@github.com>