Re: [w3c/permissions] Require an explicit origin for WebDriver BiDi automation (PR #436)

@miketaylr requested changes on this pull request.

Looks good - just some minor nits.

>            </li>
           <li>Let |targets| be a <a>list</a> containing all [=environment settings objects=] whose
-          [=environment settings object/origin=] is [=same origin=] as the [=environment settings
-          object/origin=] of |settings|.
+          [=environment settings object/origin=] is [=same origin=] as |target origin|.

```suggestion
          [=environment settings object/origin=] is [=same origin=] with |target origin|.
```

> @@ -1232,14 +1232,15 @@ <h2 id="automation">
       <div class="algorithm">
         <p>
           To <dfn data-for="WebDriver">set a permission</dfn> given a {{PermissionDescriptor}}
-          |descriptor:PermissionDescriptor|, and a {{PermissionState}} |state:PermissionState|:
+          |descriptor:PermissionDescriptor|, a {{PermissionState}} |state:PermissionState|, and an
+          |origin|:

Let's change this to "and an optional origin", then we don't have to pass in null down on line 1328.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/436#pullrequestreview-1819187415
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/436/review/1819187415@github.com>