Re: [whatwg/dom] Reset declarative to false when calling attachShadow (PR #1245)

@annevk commented on this pull request.



> @@ -6965,8 +6965,16 @@ a boolean <var>delegatesFocus</var>, and a boolean <var>slotAssignment</var>:
    is false, then <a>throw</a> an "{{NotSupportedError!!exception}}" {{DOMException}}.
 
    <li>
-    <p>Otherwise, <a for=/>remove</a> all of <var>element</var>'s <a for=Element>shadow root</a>'s
-    <a for=tree>children</a>, in <a>tree order</a>, and return.
+    <p>Otherwise:
+
+    <ol>
+      <li><p><a for=/>Remove</a> all of <var>element</var>'s <a for=Element>shadow root</a>'s

Single-space indentation.

> @@ -6965,8 +6965,16 @@ a boolean <var>delegatesFocus</var>, and a boolean <var>slotAssignment</var>:
    is false, then <a>throw</a> an "{{NotSupportedError!!exception}}" {{DOMException}}.
 
    <li>
-    <p>Otherwise, <a for=/>remove</a> all of <var>element</var>'s <a for=Element>shadow root</a>'s
-    <a for=tree>children</a>, in <a>tree order</a>, and return.
+    <p>Otherwise:
+
+    <ol>
+      <li><p><a for=/>Remove</a> all of <var>element</var>'s <a for=Element>shadow root</a>'s
+      <a for=tree>children</a>, in <a>tree order</a>.
+
+      <li><p>Set <var>element</var>'s <a for=Element>shadow root</a>'s <a for=ShadowRoot>declarative</a> to false.

100 columns.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1245#pullrequestreview-1812885766
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1245/review/1812885766@github.com>