- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 08 Jan 2024 20:16:05 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 9 January 2024 04:16:11 UTC
@domenic commented on this pull request.
> @@ -6895,8 +6895,8 @@ to grow organically as needed.
otherwise. If this throws an exception |e|, return [=a promise rejected with=] |e|.
1. If |result| is a {{Promise}}, then return |result|.
1. Return [=a promise resolved with=] undefined.
- 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps:
- 1. Let |result| be the result of running |cancelAlgorithm|, if |cancelAlgorithm| was given, or
+ 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps given |reason|:
+ 1. Let |result| be the result of running |cancelAlgorithm| given |reason|, if |cancelAlgorithm| was given, or
It looks like CONTRIBUTING.md is outdated; 100 would be best, please!
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1300#discussion_r1445608305
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/streams/pull/1300/review/1810376905@github.com>
Received on Tuesday, 9 January 2024 04:16:11 UTC