- From: lexx9999 <notifications@github.com>
- Date: Thu, 29 Feb 2024 15:36:36 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 29 February 2024 23:36:40 UTC
Compared to Firefox there are actually two dark mode settings, one for the content and another one for the application. Which can be different. Query css from background/event pages get the application setting, normal pages (including extension pages) get the content setting. BTW: I also crossed this issue when changing an action item. Therefore the correct place to provide this info would be (IMO) the action API (and pageAction). E.g. action.visualMode() returning string 'dark' or 'light'; Might return a promise; And/or extending the map for setIcon to something like ``` { "16": "fallback.png", "dark": {"16": "dark.png" }, "light": { "16": "light.png" } } ``` but that would leave the problem for dynamically created icons. IMO this is not a css issue, css is just misused to fix the problem. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/issues/1577#issuecomment-1972151864 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/issues/1577/1972151864@github.com>
Received on Thursday, 29 February 2024 23:36:40 UTC