- From: Marijn Kruisselbrink <notifications@github.com>
- Date: Thu, 15 Feb 2024 16:45:38 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 16 February 2024 00:45:42 UTC
@mkruisselbrink commented on this pull request. > @@ -3175,6 +3283,103 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ 1. Return |response|. </section> + <section algorithm> + <h3 id="parse-urlpattern-algorithm"><dfn>Parse URL Pattern</dfn></h3> + : Input + :: |rawPattern|, a {{URLPatternCompatible}} + :: |serviceWorker|, a [=/service worker=] + : Output + :: {{URLPattern}} + + 1. Let |baseURL| be |serviceWorker|'s [=service worker/script url=]. + 1. Return the result of [=building a URLPattern from a Web IDL value=] |rawPattern| given |baseURL| and |serviceWorker|'s [=service worker/global object=]'s [=relevant realm=]. Thanks, please mention that issue in the spec algorithm here as explanation why it is "okay" (or at least the best we can do for now) to pass in serviceWorker's global object's relevant realm, even though we call this algorithm from places where such a thing doesn't exist. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1701#discussion_r1491832454 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1701/review/1884134040@github.com>
Received on Friday, 16 February 2024 00:45:42 UTC