- From: Yoshisato Yanagisawa <notifications@github.com>
- Date: Tue, 13 Feb 2024 18:31:03 -0800
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 14 February 2024 02:31:10 UTC
@yoshisatoyanagisawa commented on this pull request. > + typedef (RouterSourceDict or RouterSourceEnum) RouterSource; + + dictionary RouterSourceDict { + DOMString cacheName; + }; + + enum RunningStatus { "running", "not-running" }; + enum RouterSourceEnum { "cache", "fetch-event", "network" }; + </pre> + + <section> + <h4 id="register-router-method">{{InstallEvent/addRoutes(rules)|event.addRoutes(rules)}}</h4> + + {{InstallEvent/addRoutes(rules)}} registers this service worker the rules to offload simple tasks that the fetch handler does. + + The <dfn method for="InstallEvent"><code>addRoutes(|rules|)</code></dfn> method steps are: Good catch! I changed the algorithm to return promise. Please see https://github.com/yoshisatoyanagisawa/ServiceWorker/pull/12 -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1701#discussion_r1488815467 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1701/review/1879268177@github.com>
Received on Wednesday, 14 February 2024 02:31:10 UTC