Re: [whatwg/dom] Enforce same parameters for attachShadow on declarative shadow root (PR #1246)

@annevk commented on this pull request.



> @@ -6958,8 +6960,20 @@ a boolean <var>delegatesFocus</var>, and a boolean <var>slotAssignment</var>:
   <p>If <var>element</var> is a <a for=Element>shadow host</a>, then:
 
   <ol>
-   <li><p>If <var>element</var>'s <a for=Element>shadow root</a>'s <a for=ShadowRoot>declarative</a>
-   is false, then <a>throw</a> an "{{NotSupportedError!!exception}}" {{DOMException}}.
+   <li><p>Let <var>currentShadowRoot</var> be <var>element</var>'s

Since you initialize this you should also use it in steps further down.

> @@ -4502,6 +4502,8 @@ dom-Range-extractContents, dom-Range-cloneContents -->
   <a for=ShadowRoot>clonable</a> is true:
 
   <ol>
+   <li><p>Assert: <var>copy</var> is not a <a for=Element>shadow host</a>.

(It's weird that this has for=Element, but that's a pre-existing issue.)

> @@ -6958,8 +6960,20 @@ a boolean <var>delegatesFocus</var>, and a boolean <var>slotAssignment</var>:
   <p>If <var>element</var> is a <a for=Element>shadow host</a>, then:
 
   <ol>
-   <li><p>If <var>element</var>'s <a for=Element>shadow root</a>'s <a for=ShadowRoot>declarative</a>
-   is false, then <a>throw</a> an "{{NotSupportedError!!exception}}" {{DOMException}}.
+   <li><p>Let <var>currentShadowRoot</var> be <var>element</var>'s
+   <a for=Element>shadow root</a>.
+
+   <li>
+    <p>If one of the following is true:
+
+    <ul>
+     <li><p><var>currentShadowRoot</var>'s <a for=ShadowRoot>declarative</a> is false,
+
+     <li><p><var>currentShadowRoot</var>'s <a for=ShadowRoot>mode</a> does not match
+     <var>mode</var>, or

It should move up one bullet point I think.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1246#pullrequestreview-1877813777
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1246/review/1877813777@github.com>