Re: [whatwg/fetch] Add WebDriver BiDi network request logging (PR #1540)

@annevk commented on this pull request.

Question about the overview still stands. Looks good otherwise.

> @@ -2157,6 +2157,11 @@ Unless stated otherwise, it is false.
 
 <p class=note>This is for exclusive use by HTML's navigate algorithm. [[!HTML]]
 
+<p>A <a for=/>request</a> has an associated <dfn export for=request>navigation id</dfn>
+(null or a string). Unless stated otherwise, it is null.
+
+<p class=note>This is for exclusive use by HTML's navigate algorithm. [[!HTML]]

What do you think about calling these fields "WebDriver navigation id" and "WebDriver id"? If we ever make them more generic we can rename them and the way WebDriver consumes them can just be as ID, but at least that would discourage others from using them for purposes they're not intended for without additional review.

> @@ -2274,7 +2287,9 @@ is to return the result of <a>serializing a request origin</a> with <var>request
 
 <ol>
  <li><p>Let <var>newRequest</var> be a copy of <var>request</var>, except for its
- <a for=request>body</a>.
+ <a for=request>body</a> and <a for=request>id</a>.
+
+ <li><p>Set <var>newRequest</var>'s <a for=request>id</a> to a new unique string.

Is this a UUID in practice? Do we just want to settle on that?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1540#pullrequestreview-1856219668
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1540/review/1856219668@github.com>