- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 27 Aug 2024 07:09:35 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 27 August 2024 14:09:39 UTC
@annevk commented on this pull request. > + <li><p>Let <var>return node</var> be the result of <a>pre-inserting</a> <var>node</var> into + <a>this</a> before <var>child</var>.</p></li> It'd be good to have more details. Because you can't move a `DocumentFragment` so a vast number of checks don't apply. Adopt won't ever run. There might be a number of range and shadow tree checks that end we end up duplicating, but perhaps that calls for abstracting those instead. At least to me a state flag seems rather unappealing. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1307#discussion_r1732930573 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1307/review/2263496130@github.com>
Received on Tuesday, 27 August 2024 14:09:39 UTC