- From: Christian Liebel <notifications@github.com>
- Date: Thu, 22 Aug 2024 11:27:31 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/pull/1140@github.com>
The three browser engines trim the `dir`, `display`, `orientation`, text, and color values, but it is not mentioned in the specification. This PR adds this as an extra step to the algorithms that process those values. Example: * [Chromium](https://github.com/chromium/chromium/blob/main/third_party/blink/renderer/modules/manifest/manifest_parser.cc#L691) * [Gecko](https://github.com/mozilla/gecko-dev/blob/master/dom/manifest/ManifestProcessor.sys.mjs#L187) * [WebKit](https://github.com/WebKit/WebKit/blob/main/Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp#L196) --- This change (choose at least one, delete ones that don't apply): * Makes editorial changes (changes informative sections, or changes normative sections without changing behavior) Implementation commitment (delete if not making normative changes): * [x] WebKit (https://bugs.webkit.org) * [x] Chromium (https://bugs.chromium.org/) * [x] Gecko (http://bugzilla.mozilla.org) Commit message: Editorial: Trim `dir`, `display`, `orientation`, text and color values Person merging, please make sure that commits are squashed with one of the following as a commit message prefix: * chore: * editorial: * BREAKING CHANGE: * And use none if it's a normative change <!-- This comment and the below content is programmatically generated. You may add a comma-separated list of anchors you'd like a direct link to below (e.g. #idl-serializers, #idl-sequence): Don't remove this comment or modify anything below this line. If you don't want a preview generated for this pull request, just replace the whole of this comment's content by "no preview" and remove what's below. --> *** <a href="https://pr-preview.s3.amazonaws.com/w3c/manifest/pull/1140.html" title="Last updated on Aug 22, 2024, 6:27 PM UTC (ca43e7d)">Preview</a> | <a href="https://pr-preview.s3.amazonaws.com/w3c/manifest/1140/84b2080...ca43e7d.html" title="Last updated on Aug 22, 2024, 6:27 PM UTC (ca43e7d)">Diff</a> You can view, comment on, or merge this pull request online at: https://github.com/w3c/manifest/pull/1140 -- Commit Summary -- * Editorial: Trim `dir`, `display`, `orientation`, text and color values -- File Changes -- M index.html (15) -- Patch Links -- https://github.com/w3c/manifest/pull/1140.patch https://github.com/w3c/manifest/pull/1140.diff -- Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/pull/1140 You are receiving this because you are subscribed to this thread. Message ID: <w3c/manifest/pull/1140@github.com>
Received on Thursday, 22 August 2024 18:27:35 UTC