- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 12 Aug 2024 06:57:27 -0700
- To: whatwg/url <url@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 12 August 2024 13:57:31 UTC
This appears to be a misunderstanding. While the port indeed does not get changed, the underlying URL has been manipulated (in particular its host) as part of the host state. You are correct that callers ignore the failure return value, but I don't think that warrants introducing additional branching to return nothing for those specific callers. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/url/issues/831#issuecomment-2284063421 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/url/issues/831/2284063421@github.com>
Received on Monday, 12 August 2024 13:57:31 UTC