Re: [w3c/manifest] Add members for localization (PR #1101)

@dmurph commented on this pull request.

Still LGTM, one suggestion to change the example.

> +        <aside class="example">
+          <p>
+            For example, the [=manifest/name=] member is a [=localizable
+            member=], and `name_localized` is its corresponding
+            [=manifest/*_localized=] member.
+          </p>
+        </aside>
+        <p>
+          A <dfn>language map</dfn> is an [=ordered map=] whose key is a
+          [=language tag=] and whose value is a [=localized value=]. The
+          <dfn>localized value</dfn> is content localized in the language given
+          by the key.
+        </p>
+        <aside class="example" title="Localizing the application name">
+          <pre class="json">
+            {

In order to make it obvious why one might want to have a different 'lang' for an entry in here, perhaps we should use a company that so it would have opinions about name pronunciations in other languages.

L'Occitane is a good example - using wikipedia you can see that sometimes is uses the french version, while other times it has a translated name. For cases like English & German, screen readers should read the name in a french pronunciation. 

```suggestion
            {
              "lang": "fr",
              "dir": "ltr",
              "name":  "L'Occitane",
              "name_localized": {
                "en":  { value: "L'Occitane", "lang": "fr" },
                "de":  { value:  "L'Occitane", "lang": "fr" },
                "zh":  "歐舒丹"
                "en-GB": {"value": "L'Occitane en Provence", "lang": "fr" },
                "fr":    "L'Occitane",
                "ar":    {value: "لوکسیتان",  "dir": "rtl"}
              }
            }
```

> @@ -2298,7 +2556,9 @@ <h3>
         </h3>
         <p>
           The <dfn>application's name</dfn> is derived from either the
-          [=manifest/name=] member or [=manifest/short_name=] member.
+          [=manifest/name=] member or [=manifest/short_name=] member. The user

In Chromium we use them depending on UX needs. It's not implemented, but I would like to follow similar rules for extensions - `short_name` is truncated to 12 characters and `name` is truncated to 75.

This sets expectations for devs, and allows the user agent to show an app name where there might not be much space.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/pull/1101#pullrequestreview-2214186976
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/manifest/pull/1101/review/2214186976@github.com>