Re: [w3c/gamepad] Add extended buttons to support trackpad (#191) (PR #196)

@marcoscaceres commented on this pull request.



> +          button types termed {{GamepadButtonType}}, and have expanded the {{GamepadButton}}
+          interface to encompass this new button type enumeration.
+       </p>
+       <section>
+          <h3>
+            <dfn>GamepadButtonType</dfn> Enum
+          </h3>
+          <p>
+            This enum defines the set of possible button types.
+          </p>
+          <pre class="idl">
+            enum GamepadButtonType {
+              "standard",
+              "non-canonical",
+               "trackpad", 
+               // ... More enum types to be defined by the separate W3C wiki page.

We can do this, but we need to change GamepadButtonType to an DOMString. Otherwise, the enum will always be out of date. Alternatively, we don't use the Wiki and just use the spec... it might be better to just use the spec, so we can have more oversight over what is defined here (and get better interop).  

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/196#pullrequestreview-2030288000
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/196/review/2030288000@github.com>