Re: [whatwg/fetch] Rename http3Only to requireUnreliable (PR #1745)

@jan-ivar commented on this pull request.



> +   <li>
+    <p>If <var>requireUnreliable</var> is true, then establish a connection capable of unreliable
+    transport, e.g., HTTP/3. [[!HTTP3]]
 
-   <li><p>When establishing an HTTP/3 connection, include SETTINGS_ENABLE_WEBTRANSPORT with a value
-   of 1 and H3_DATAGRAM with a value of 1 in the initial SETTINGS frame. [[!WEBTRANSPORT-HTTP3]]
-   [[!HTTP3-DATAGRAM]]
+    <p>When establishing such a connection, include SETTINGS_ENABLE_WEBTRANSPORT with a value of 1
+    and H3_DATAGRAM with a value of 1 in the initial SETTINGS frame. [[!WEBTRANSPORT-HTTP3]]
+    [[!HTTP3-DATAGRAM]]

> Perhaps this second paragraph should remain "When establishing an HTTP/3 connection"?

I agree the new prose is better, but think it needs to remain a second paragraph.

The dropping of `<li>` moves this into the if-sentence above. Before it said:

<img width="779" alt="image" src="https://github.com/whatwg/fetch/assets/3136226/5abc109f-d4e2-4cff-91e4-537c92c67e89">

...which covers setting SETTINGS_ENABLE_WEBTRANSPORT etc. when an HTTP/3 connection is  established even when [requireUnreliable](https://w3c.github.io/webtransport/#dom-webtransportoptions-requireunreliable) is false (which is the default).

But now it says to only do that if `requireUnreliable` is true, which seems wrong:
<img width="941" alt="image" src="https://github.com/whatwg/fetch/assets/3136226/6ca1ec25-f38d-4214-bfcb-42830ca7a425">


-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1745#discussion_r1578222835
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1745/review/2020431034@github.com>