Re: [whatwg/dom] Integration with trusted types inside of node conversion (PR #1258)

@annevk commented on this pull request.



> +     <li><p><a for=list>Append</a> <var>newValue</var> to <var>newNodes</var>.
+    </ol>
+
+   <li>
+    <p>Otherwise, if <var>value</var> is a {{TrustedScript}}:
+
+    <ol>
+     <li><p>Let <var>newValue</var> be a new {{Text}} <a for=/>node</a> whose
+     <a for=CharacterData>data</a> is <var>value</var>'s <a for=TrustedScript>\[[Data]]</a>
+     internal slot value and <a for=Node>node document</a> is <var>document</var>.
+
+     <li><p><a for=list>Append</a> <var>newValue</var> to <var>newNodes</var>.
+    </ol>
+
+   <li><p>Otherwise, <a for=list>append</a> <var>value</var> to <var>newNodes</var>.
+ </ol>

Indentation is wrong here. I think this `</ol>` just needs an additional space?

> @@ -3040,12 +3042,49 @@ standards that want to define APIs shared between <a for=/>documents</a> and
  <a for=CharacterData>data</a> is the string and <a for=Node>node document</a> is
  <var>document</var>.
 
- <li><p>If <var>nodes</var> contains one <a for=/>node</a>, then set <var>node</var> to
- <var>nodes</var>[0].
+ <li><p>Let <var>isScriptElement</var> be true if <var>parent</var> is an {{HTMLScriptElement}}
+ <a for=/>node</a>; otherwise false.
+
+ <li><p>Let <var>newNodes</var> be the empty list.
+
+ <li>
+  <p><a for=list>For each</a> <var>value</var> of <var>nodes</var>:
+
+  <ol>
+   <li>
+    <p>If <var>value</var> is a {{Text}} <a for=/>node</a>, and <var>isScriptElement</var>

```suggestion
    <p>If <var>value</var> is a {{Text}} <a for=/>node</a> and <var>isScriptElement</var>
```

> @@ -3040,12 +3042,49 @@ standards that want to define APIs shared between <a for=/>documents</a> and
  <a for=CharacterData>data</a> is the string and <a for=Node>node document</a> is
  <var>document</var>.
 
- <li><p>If <var>nodes</var> contains one <a for=/>node</a>, then set <var>node</var> to
- <var>nodes</var>[0].
+ <li><p>Let <var>isScriptElement</var> be true if <var>parent</var> is an {{HTMLScriptElement}}
+ <a for=/>node</a>; otherwise false.
+
+ <li><p>Let <var>newNodes</var> be the empty list.

```suggestion
 <li><p>Let <var>newNodes</var> be « ».
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1258#pullrequestreview-2003410682
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1258/review/2003410682@github.com>