- From: Luke Warlow <notifications@github.com>
- Date: Wed, 10 Apr 2024 08:17:14 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 10 April 2024 15:17:18 UTC
@lukewarlow commented on this pull request. > + <ol> + <li><p>Set <var>attribute</var> to a new <a>attribute</a> whose <a for=Attr>namespace</a> is + <var>namespace</var>, <a for=Attr>namespace prefix</a> is <var>prefix</var>, + <a for=Attr>local name</a> is <var>localName</var> and <a for=Node>node document</a> is + <var>element</var>'s <a for=Node>node document</a>. + + <li><p><a>Validate and set attribute value</a> <var>value</var> for <var>attribute</var> with + <var>element</var>. + + <li><p><a lt="append an attribute">Append</a> <var>attribute</var> to <var>element</var>. + + <li><p>Return. + </ol> Having said that we can reorder these steps so that step 4 is inside of 5's if so it becomes 5.1 and 5.2 is to replace? And then we can append attr and handle validation inside of append? (I've also just spotted it refers to a newAttr which doesn't exist in this algorithm I'll make sure to fix that) -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1247#discussion_r1559642749 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1247/review/1992011708@github.com>
Received on Wednesday, 10 April 2024 15:17:18 UTC