Re: [whatwg/dom] Expose Node/textContent getter and setter steps (PR #1271)

@annevk commented on this pull request.

Looks good modulo inline comments that also apply to the set side.

> @@ -4286,24 +4286,27 @@ empty string instead, and then do as described below, switching on the interface
  <dd><p>Do nothing.
 </dl>
 
-<p>The <dfn attribute for=Node><code>textContent</code></dfn> getter steps are to return the
-following, switching on the interface <a>this</a> <a>implements</a>:
+<p>To <dfn export>get textContent</dfn> with a <a for=/>node</a> <var>node</var>,

"get text content"

We generally use sentences for algorithm names. Camelcase is used for variables.

> +<p>The <dfn attribute for=Node><code>textContent</code></dfn> getter steps are to
+<a>get textContent</a> with <a>this</a>.

I think you have to say "return the result of running get text content" here. Returning doesn't happen by magic and not invoking it with "run" also feels a bit weird given how the algorithm is named.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1271#pullrequestreview-1976504267
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1271/review/1976504267@github.com>