- From: Marcos Cáceres <notifications@github.com>
- Date: Thu, 26 Oct 2023 11:53:31 -0700
- To: w3c/pointerlock <pointerlock@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 26 October 2023 18:53:36 UTC
@marcoscaceres commented on this pull request. > + current [=pointer-lock options=] and [=options=] are not + supported: + <ol> + <li>[=Queue an element task=] on the [=user interaction + task source=], given this, to perform the following steps: + <ol type='i'> + <li>[=Reject=] <var>promise</var> with a + "{{NotSupportedError}}" {{DOMException}}. + </li> + </ol> + </li> + <li>Return <var>promise</var>. + </li> + </ol> + </li> + <li>If [=options=] are not equivalent to the current We don't think we need to go here is we prevent the method from being called more than once. Having a flag will prevent getting into this weird override with supported situation. Let's please simplify all this unless there is an actual use case for calling lock more than once without unlocking first. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/pointerlock/pull/49#pullrequestreview-1700418971 You are receiving this because you are subscribed to this thread. Message ID: <w3c/pointerlock/pull/49/review/1700418971@github.com>
Received on Thursday, 26 October 2023 18:53:36 UTC