Re: [w3c/pointerlock] Add lock options to requestPointerLock (#49)

@marcoscaceres commented on this pull request.



> +                <li>[=Queue an element task=] on the [=user interaction task
+                source=], given this, to perform the following steps:
+                  <ol>
+                    <li>[=Fire an event=] named {{pointerlockerror}} at
+                    [=this=]'s [=Node/node document=].
+                    </li>
+                    <li>[=Reject=] <var>promise</var> with a
+                    "{{InvalidStateError}}" {{DOMException}}.
+                    </li>
+                  </ol>
+                </li>
+                <li>Return <var>promise</var>.
+                </li>
+              </ol>
+            </li>
+            <li>If the user agent's [=pointer-lock target=]'s

why don't just have flag to prevent you call the method twice? It seems complicated to check for object equality. 

What's the actual use case for calling the method twice? Why not unlock and lock again? 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/pointerlock/pull/49#pullrequestreview-1700401087
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/pointerlock/pull/49/review/1700401087@github.com>

Received on Thursday, 26 October 2023 18:49:15 UTC