- From: Brady Eidson <notifications@github.com>
- Date: Wed, 18 Oct 2023 09:23:58 -0700
- To: w3c/push-api <push-api@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 18 October 2023 16:24:03 UTC
> The current [`NotificationOptions`](https://notifications.spec.whatwg.org/#dictdef-notificationoptions) already include [`badge`](https://notifications.spec.whatwg.org/#dom-notificationoptions-badge). There's a potential confusion with your proposed `appBadge` (camelCased your original `app_badge`, as per my suggestion in [#360 (comment)](https://github.com/w3c/push-api/issues/360#issuecomment-1721039328)). I do reckon that `appBadge` is a perfect name given the intended use case, though, so the potential for confusion might just be something to live with. We discussed this. Putting `appBadge` on NotificationOptions is necessary, and we can't change the old `badge` for backwards compatibility. There is potential for confusion, but the typing (string vs. uint64_t) and docs will help. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/push-api/issues/360#issuecomment-1768900869 You are receiving this because you are subscribed to this thread. Message ID: <w3c/push-api/issues/360/1768900869@github.com>
Received on Wednesday, 18 October 2023 16:24:03 UTC