Re: [w3c/clipboard-apis] Add 'starts with' to web custom format prefix. (PR #195)

@evanstade commented on this pull request.

Sorry for delay --- I was OOO from the middle of last week.

> @@ -717,7 +719,7 @@ url: https://w3c.github.io/permissions/#permissions-task-source; type: dfn;
 
    1. Let |isCustom| be |false|.
 
-   1. If |type| has "web "("web" followed by U+0020 SPACE) prefix, then:
+   1. If |type| [=string/starts with=] "web "("web" followed by U+0020 SPACE) prefix, then:

nit: there is a space missing before the opening parenthesis.

That said I think it would be more legible (and more idiomatic) to write this as `"web "` (i.e. \`"web "\`). I think it's overkill and somewhat distracting to copy the full parenthetical in every location.

> @@ -717,7 +719,7 @@ url: https://w3c.github.io/permissions/#permissions-task-source; type: dfn;
 
    1. Let |isCustom| be |false|.
 
-   1. If |type| has "web "("web" followed by U+0020 SPACE) prefix, then:
+   1. If |type| [=string/starts with=] "web "("web" followed by U+0020 SPACE) prefix, then:
    
     1. Remove "web " prefix and set the remaining string to |type|.

other like this one should also be wrapped with backticks.

> @@ -1695,7 +1697,7 @@ url: https://w3c.github.io/permissions/#permissions-task-source; type: dfn;
 
     1. Let |webCustomFormat| be an empty {{Blob/type}}.
 
-    1. If |webCustomFormatString| has "web "("web" followed by U+0020 SPACE) prefix, then remove the "web " prefix and store the remaining string in |webCustomFormat|'s {{Blob/type}}'s [=MIME type/essence=], else abort all steps.
+    1. If |webCustomFormatString| [string/starts with=] "web "("web" followed by U+0020 SPACE) prefix, then remove the "web " prefix and store the remaining string in |webCustomFormat|'s {{Blob/type}}'s [=MIME type/essence=], else abort all steps.

Does this step need to check if the rest of the string resembles a valid mime type (without parameters)?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/clipboard-apis/pull/195#pullrequestreview-1685245087
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/clipboard-apis/pull/195/review/1685245087@github.com>